Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After resampling the tile size needs to be rounded up in tileiterator #538

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Conversation

jonasteuwen
Copy link
Contributor

Tile size can be erroneously rounded to the integer value, while it needs to be rounded up. This would resolve #440.

@jonasteuwen
Copy link
Contributor Author

The failure seems to be in python install, not in the code.

@manthey
Copy link
Member

manthey commented Jan 25, 2021

Thank you @jonasteuwen. The CI failure was transient and rerunning it passed.

@manthey manthey merged commit 6f470dd into girder:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect tile size from tileiterator: requested tile_size not explicitly respected
2 participants