add annotation badge to large image preview #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sgratzl
commented
Sep 26, 2019
sgratzl
commented
|
One minor issue: You can optionally change the large_image plugin settings to show label and macro images. The badge currently appears on all images; it should just be shown on one of them (just the thumbnail, I think).
|
|
please try again |
|
Great. The linter is complaining about two extra lines (see the output of the circle build). |
|
@sgratzl If you didn't see it, circle now shows a linting error in the styl file. |
manthey
approved these changes
Oct 4, 2019
This was referenced Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.