Add support for DICOMweb range requests #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psavery
force-pushed
the
dicomweb-range-requests
branch
3 times, most recently
from
20b7406 to
b18de4f
Compare
When a range request is made or a fuse mount is attempted, we compute the size of the DICOM file. Currently, the only reliable way that we know to do this is by streaming the whole file and counting the total bytes read. After the file size is computed, it is saved in `file['size']` so it does not need to be computed again. Then, the range requests can be successfully made, complete with accurate `Content-Length` and `Content-Range` headers. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
dicomweb-range-requests
branch
from
b18de4f to
4760bda
Compare
manthey
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a range request is made or a fuse mount is attempted, we compute the size of the DICOM file. Currently, the only reliable way that we know to do this is by streaming the whole file and counting the bytes read.
After the file size is computed, it is stored in
file['size']so it does not need to be computed again. Then, the range requests can be successfully made, complete with accurateContent-LengthandContent-Rangeheaders.