Update WsiDicomWebClient init call #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of the latest `wsidicom` release (0.13.0), the new `__init__` method just takes a `DICOMwebClient` object. The old `__init__` method was moved to the class method `create_client()`. So we need to update the way we initialize it. In girder#1349, we are adding authentication where we create the DICOMwebClient object ourselves, so go ahead and do that now to simplify that one. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
update-wsidicom-init
branch
from
6a3f0f3 to
3cf9860
Compare
manthey
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the latest
wsidicomrelease (0.13.0), the new__init__method just takes aDICOMwebClientobject. The old__init__method was moved to the class methodcreate_client(). So we need to update the way we initialize it.In #1349, we are adding authentication where we create the DICOMwebClient object ourselves, so go ahead and do that now to simplify that one.