Add DICOMweb filters and "limit" parameter #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psavery
commented
Oct 3, 2023
sources/dicom/large_image_source_dicom/web_client/templates/assetstoreImport.pug
Outdated
Show resolved
Hide resolved
psavery
commented
Oct 3, 2023
sources/dicom/large_image_source_dicom/web_client/views/AssetstoreImportView.js
Outdated
Show resolved
Hide resolved
psavery
force-pushed
the
dicomweb-filters
branch
from
5c2eede to
075ff87
Compare
manthey
reviewed
Oct 18, 2023
manthey
reviewed
Oct 18, 2023
sources/dicom/large_image_source_dicom/web_client/views/AssetstoreImportView.js
Show resolved
Hide resolved
This is forwarded directly to the DICOMweb client's `search_for_series()`
function.
```json
{
"PatientID": "ABC123"
}
```
Signed-off-by: Patrick Avery <[email protected]>
This will limit the number of DICOMweb objects that are imported. Signed-off-by: Patrick Avery <[email protected]>
Signed-off-by: Patrick Avery <[email protected]>
This checks the use of filter parameters and several validation steps. Signed-off-by: Patrick Avery <[email protected]>
Signed-off-by: Patrick Avery <[email protected]>
Signed-off-by: Patrick Avery <[email protected]>
They get validated already on the server, so this is not needed. Signed-off-by: Patrick Avery <[email protected]>
It is not needed. Signed-off-by: Patrick Avery <[email protected]>
Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
dicomweb-filters
branch
from
5d223d0 to
f16158b
Compare
Signed-off-by: Patrick Avery <[email protected]>
Signed-off-by: Patrick Avery <[email protected]>
manthey
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a JSON text area for DICOMweb filters
This is forwarded directly to the DICOMweb client's
search_for_series()function. Example:
{ "PatientID": "ABC123" }This also adds a "limit" parameter to limit the number of studies that get searched. It defaults to 100.
Currently, these options appear like this:
Fixes: #1312