-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial DICOMweb support #1303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psavery
force-pushed
the
dicomweb
branch
8 times, most recently
from
September 18, 2023 16:06
854b152
to
77fc7a2
Compare
manthey
reviewed
Sep 18, 2023
manthey
reviewed
Sep 18, 2023
manthey
reviewed
Sep 18, 2023
sources/dicom/large_image_source_dicom/assetstore/dicomweb_assetstore_adapter.py
Outdated
Show resolved
Hide resolved
manthey
reviewed
Sep 18, 2023
sources/dicom/large_image_source_dicom/assetstore/dicomweb_assetstore_adapter.py
Show resolved
Hide resolved
psavery
force-pushed
the
dicomweb
branch
3 times, most recently
from
September 18, 2023 22:01
2b50860
to
da2cbb7
Compare
manthey
reviewed
Sep 19, 2023
manthey
reviewed
Sep 19, 2023
sources/dicom/large_image_source_dicom/web_client/templates/assetstoreImport.pug
Outdated
Show resolved
Hide resolved
manthey
reviewed
Sep 19, 2023
manthey
reviewed
Sep 19, 2023
psavery
force-pushed
the
dicomweb
branch
2 times, most recently
from
September 20, 2023 10:22
c33085c
to
87b3241
Compare
manthey
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fantastic start.
This creates a new DICOMweb assetstore that is used to track resources on a DICOMweb server. The user provides the DICOMweb server URL and optionally QIDO and WADO prefixes (if the server requires them). The user is then able to import references to the objects on the DICOMweb server. The files that are created via this assetstore are able to be viewed with the dicom tile source, which has been extended to handle files on a DICOMweb server. A test was also added that utilizes the public DICOMweb server located [here](https://imagingdatacommons.github.io/slim/). There is still more work to do in future PRs, including: * Adding a search/filter capability * Adding authentication for non-public servers * Query and store metadata from the DICOMweb objects Fixes: girder#1204 Signed-off-by: Patrick Avery <[email protected]>
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new DICOMweb assetstore that is used to track resources on a DICOMweb server. The user provides the DICOMweb server URL and optionally QIDO and WADO prefixes (if the server requires them). The user is then able to import references to the objects on the DICOMweb server.
The files that are created via this assetstore are able to be viewed with the dicom tile source, which has been extended to handle files on a DICOMweb server.
A test was also added that utilizes the public DICOMweb server located here.
There is still more work to do in future PRs, including:
Fixes: #1204