Closing some styled sources could premature close file handles #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be reproduced by opening an nd2 file, opening another instance of it with a bad style, then trying to open another instance of it with a good style. The file handles would get closed with the bad style, and then subsequent reads of a good style would fail (and even could segfault).
manthey
force-pushed
the
fix-bad-style-handles
branch
from
75397bc to
88b19cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be reproduced by opening an nd2 file, opening another instance of it with a bad style, then trying to open another instance of it with a good style. The file handles would get closed with the bad style, and then subsequent reads of a good style would fail (and even could segfault).