-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create, select, and delete image view presets #1237
Conversation
c2e21e6
to
c0599fd
Compare
Is there any way to close the "new preset" after it has been expanded? Maybe clicking the plus again would hide it. It feel like once you start creating a present you are stuck doing so. |
girder/girder_large_image/web_client/vue/components/PresetsMenu.vue
Outdated
Show resolved
Hide resolved
Yes, I can do that. Changed in 312e6ed |
This is an opinion question (not necessarily a problem). I created a preset with a selection. I then decided it wasn't as good as it could be, so I twiddled some settings. To replace an existing preset without recreating the settings manually, I then have to (1) create a new preset with a name I don't want, (2) switch to the old version, (3) delete it, (4) switch to the undesired name, (5) create a new preset with the original name, (6) switch back to the undesired name, (7) delete it. Obviously, replacing an existing preset should have some warning, but refusing to replace it makes updating a present hard. What if instead when there was a name collision the "Save preset" button changed to "Update preset"? |
'frame': this.currentFrame, | ||
'style': this.currentStyle, | ||
} | ||
if (this.availablePresets.find((p) => p.name === newPreset.name)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should trim the name before comparison and saving it. I made a preset called "foo" and it let me create "foo ", which looks like a name collision.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in 4ced213
|
Would it be possible to compare the current frame and style values and switch the preset drop down to "Select a preset" when things are changed and switch to a specific preset when they match? |
You can't switch back to a preset with spaces at the end of its name. |
On a multi-axis preset, I set each axis to a different value and it then render it as if the first axis was the overall frame number and the other axes were 0. |
Good idea. Changed in 4ced213. |
4e436e9
to
97b67e9
Compare
Added in 7f37a10 |
This PR adds a widget for Image View Presets on the righthand side of the image controls.
The user doe the following:
Requesting @manthey to take a look, since this will probably need a few iterations.