Fix updating the hidden style field for the frame selector #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensure it maintains reactivity and updates for just the current mode, including clearing for non-compositing modes. Resolves #1225. Sets default band names more appropriately when there are other than 3 bands.
|
@annehaley If you have time, please look at this. I may merge it relatively soon, as the hidden style field is inconsistent with the selector state without this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensure it maintains reactivity and updates for just the current mode, including clearing for non-compositing modes.
Resolves #1225.
Sets default band names more appropriately when there are other than 3 bands.