Simplify style locking. #1224
Merged
Simplify style locking. #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just reference the unstyled instance directly. This improves speed by reducing locking.
manthey
force-pushed
the
refactor-style-locking
branch
from
c2b92de to
b157930
Compare
manthey
added a commit
that referenced
this pull request
Jun 30, 2023
PR #1224 changed how unstyled data was accessed to reduce locking. As a side effect, if you asked for the dtype from a source with a default style before asking for tile data, the result could be inconsistent. This fixes that.
manthey
added a commit
that referenced
this pull request
Jul 3, 2023
Improve how dtypes are reported from #1224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just reference the unstyled instance directly. This improves speed by reducing locking.