Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dicom source. #1005

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Add a dicom source. #1005

merged 3 commits into from
Dec 1, 2022

Conversation

manthey
Copy link
Member

@manthey manthey commented Nov 29, 2022

This uses wsidicom to read dicom files. So far it has only been tested with files that were generated with the wsi2dcm docker from the 1.0.3 deb from https://github.com/GoogleCloudPlatform/wsi-to-dicom-converter, which seems to have issues with some files.

This may be refactored to use a different base library, and internal details should be considered provisional.

@manthey
Copy link
Member Author

manthey commented Nov 30, 2022

As an implementation note, I had looked into using the dicomslide library rather than the wsidicom library. dicomslide requires numerous dicom fields to be set that are not and cannot be set via the wsi2dcm program, and therefore doesn't seem to be an easy solution.

If we want to use dicomslide, we could augment the response from the dicomweb_client to fill in the fields dicomslide requires. This still will fail in the UIDs specified in the dicom files are not conformant to the DICOM spec, whereas wsidicom doesn't care. Further, the FrameOfReferenceUID that wsi2dcm generates isn't what dicomslide expects, so that would also have to be modified.

The main virtue of dicomslide is that it can handle dicomweb and (I think) could write out data.

Support for multiple Z slices or channels can be added with either library (I think), but requires samples to validate.

This uses wsidicom to read dicom files.  So far it has only been tested
with files that were generated with the wsi2dcm docker from the 1.0.3
deb from https://github.com/GoogleCloudPlatform/wsi-to-dicom-converter,
which seems to have issues with some files.

This may be refactored to use a different base library, and internal
details should be considered provisional.

It needs to have internal metadata exposed.
@manthey manthey merged commit 1f2f0c6 into master Dec 1, 2022
@manthey manthey deleted the dicom-source branch December 1, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant