-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cubic spline interpolation header and example #14
base: master
Are you sure you want to change the base?
Conversation
Hi, thank you so much for contributing. It's weird that I am approving the CI pipeline and will review the files as soon as I have more time! |
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
===========================================
+ Coverage 47.05% 69.56% +22.50%
===========================================
Files 2 2
Lines 17 23 +6
===========================================
+ Hits 8 16 +8
+ Misses 9 7 -2
Continue to review full report at Codecov.
|
I forgot to mention that in my case, the Please let me know if I should remove the |
The code doesn't seem to compile at the moment. Regarding the multiple definitions, can you describe the sequence of commands you run when you get the error? I can't seem to reproduce it. Thank you! |
Sorry for late response. The First I ran the following command
Then,
|
Hi,
This is my first time attempting to contribute to an open source project, so my apologies for my lack of experience.
What I attempting to do is to add the cubic spline interpolation modules in this project.
Basically it's the same module as PythonRobotic cubicspline planner.
But i think the algorithm itself is not path planning, but an interpolation polynomial, therefore I've added a new workspace called Polynomial.
On the side note, seems the algorithm relies on linspace function, so I've created one in the common.h. The unit test for the linspace is included. Also, one thing iIve notice is somehow the deg2rad function causing compile error due to multiple definition, so i added inline to it.
Please let me know anything i can help to make the code better..