feat(react19): Remove findDomNode in ContextPickerModal #82635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since we only use the ref to focus, we can pass an autofocus function to the ref prop. Select has a focus that can be used.
scttcper
changed the title
github-actions
bot
added
the
Scope: Frontend
ryan953
reviewed
Dec 30, 2024
Co-authored-by: Ryan Albrecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we only use the ref to focus, we can pass an autofocus function to the ref prop. Select has a focus that can be used.
the easiest way i've found to trigger this modal currently is clicking "inbound data filters" on a bad query
part of https://github.com/getsentry/frontend-tsc/issues/68