Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color options tab for FunnelBar #7263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elro444
Copy link

@elro444 elro444 commented Dec 28, 2024

This will allow choosing a background color for the data bars when using the Funnel visualization.

What type of PR is this?

  • Feature
  • Quality of life

Description

Add an option to choose a color for the Funnel visualization.
Up until now, you could only have funnels with the cyan color, without an ability to change it.

TODO

List of tasks to complete:

  • Decide on a default color (keep the original cyan?)
  • Handle text color on dark backgrounds.
  • Support different color palettes?

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Tested manually - tweaked the colors in the visualization editor and saw the expected change.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image
image
image
(still need to fix contrast issues)
image

This will allow choosing a background color for the data bars when
using the Funnel visualization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant