Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflow trigger for publishing release image #7259

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented Dec 24, 2024

What type of PR is this?

  • Other

Description

  • If the action was not triggered manually, publish a preview image
  • Always select a branch for release image

How is this tested?

  • Manually

Tested on personal Dockerhub account

https://hub.docker.com/repository/docker/eradman/redash/general
https://hub.docker.com/repository/docker/eradman/preview/general

Related Tickets & Documents

#7251

Preview image from master

preview-image-1

Publish a release

preview-image-2

@eradman eradman requested a review from lucydodo December 24, 2024 14:24
Copy link
Member

@lucydodo lucydodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but it seems like you might have forgotten to change the username back after testing. 🤔

.github/workflows/preview-image.yml Outdated Show resolved Hide resolved
.github/workflows/preview-image.yml Outdated Show resolved Hide resolved
- If the action was not triggered manually, publish a preview image
- Always select a branch for release image
Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that repo name fixed, this looks good to merge. 😄

@justinclift justinclift merged commit b9583c0 into getredash:master Dec 27, 2024
11 checks passed
@eradman eradman deleted the release-image branch December 27, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants