Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to not allow HTML content in tables #7064

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ezraodio1
Copy link
Contributor

@ezraodio1 ezraodio1 commented Jul 17, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Change the default for each column in a table to not allow HTML. This addresses a potential security issue.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Verified that the default behavior changes when a table is created.

Related Tickets & Documents

#6615

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@ezraodio1 ezraodio1 force-pushed the change-allow-html-default branch from 57f68ca to b89fe21 Compare July 17, 2024 20:03
@eradman
Copy link
Collaborator

eradman commented Jul 29, 2024

Let's consider this change after 24.08.0-dev is tagged

@eradman eradman force-pushed the change-allow-html-default branch from b89fe21 to 7ceca00 Compare December 31, 2024 16:55
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.01%. Comparing base (c08292d) to head (7ceca00).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7064   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files         163      163           
  Lines       13410    13410           
  Branches     1905     1905           
=======================================
  Hits         8585     8585           
  Misses       4490     4490           
  Partials      335      335           

@eradman
Copy link
Collaborator

eradman commented Dec 31, 2024

Rebased this branch and tested locally.

New goal: merge after 25.01.0-dev is tagged

@justinclift
Copy link
Member

We really need to drop the leading zeros in our tag names too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants