Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable password reset #2431

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Karmalakas
Copy link
Contributor

@Karmalakas Karmalakas commented Nov 22, 2024

What title says. If reset is disabled, /forgot and /reset routes display login form. On login form "Forgot" button is hidden.
Also, when email plugin has disabled mail engine, password reset is disbled

Deafult functionality doesn't change, except if mail engine is disabled

image
image

Copy link
Contributor

@pmoreno-rodriguez pmoreno-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Karmalakas. Can you add the Spanish translations in your PR?
This is the translated text:

PASSWORD_RESET_TITLE: "Restablecer contraseña"
PASSWORD_RESET_HELP: "Habilitar restablecimiento de contraseña para las cuentas de administrador"

@Karmalakas
Copy link
Contributor Author

Can you add the Spanish translations in your PR?

Added

@eleftrik
Copy link

Thanks! IMHO, this configuration option is beneficial.
Let's say I have a small personal blog where I am the only admin user, I didn't configure any email service and I can SSH to my server in case I need to reset password, add other users, etc.
In such a scenario, it's better to hide any button/functionality about password reset.

@Karmalakas
Copy link
Contributor Author

Hi, @rhukster 🙂 Any chance this could make into next release maybe? I know you're busy with v1.8, but maybe someone from the team could take a look? Maybe there are some notes that need to be addressed first if I missed something? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants