-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs url for old actions pages #39160
Draft
aar9nk
wants to merge
4
commits into
gatsbyjs:master
Choose a base branch
from
aar9nk:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Nov 11, 2024
2 tasks
serhalp
previously approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
serhalp
added
type: documentation
An issue or pull request for improving or updating Gatsby's documentation
status: accepted
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Nov 18, 2024
@aar9nk Ah, it looks like there are some URLs that need updating in some test snapshots like gatsby/packages/gatsby/src/schema/__tests__/__snapshots__/rebuild-schema.js.snap Line 1366 in ce3b361
|
auto-merge was automatically disabled
November 24, 2024 00:53
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status: accepted
type: documentation
An issue or pull request for improving or updating Gatsby's documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a new URL for the actions page, I imagine it should be handled just with a redirect however it appears to not be working. I have opted just to fix the pages that I found throughout the code for now until I can find how redirects are working on the gatsby website.
I believe this is a quick fix, but please suggest a better option if you think this is not correct.
Documentation
N/A
Tests
N/A
Related Issues
Fixes #39159