Implement primary configuration using XDG conventions. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Primary location for config is $XDG_CONFIG_HOME/galvanize/config.yaml * Will use the ~/.glearn-config.yaml file if found * Prints a deprecation warning for using ~/.glearn-config.yaml * Adds new '--upgrade' flag to `learn set` to move ~/.glearn-config.yaml to primary location * Short and long help messages now shows location of configuration file
Eagle Eye @perrybranch-galvanize gets all the thanks for catching this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved direct use of
viperto its own packageapp/config. Now, it provides a layer of abstraction between the application's configuration management and the tech/location behind it.Functionality
learn setto move ~/.glearn-config.yaml to primary locationSecondary location deprecation warning and config file location
Upgrading config file moves it to new location
Primary and secondary locations both exist
(Notice path in help descriptions showing it is using primary location)
Run without primary and secondary locations creates primary location
Setting token value and upgrading at the same time works