Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document inserted at viewport when adjust_document is true #1088 #1239

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

strang3nt
Copy link

Small edit that fixes #1088.
The commit makes it so that when adjust_document is on the PDF is positioned at current viewport instead of position zero.

@strang3nt strang3nt marked this pull request as ready for review September 29, 2024 14:07
@flxzt
Copy link
Owner

flxzt commented Oct 25, 2024

this kind of defeats the purpose of the "adjust document" option.

This would need to be implemented differently to reflect the desire to append to the existing document, either in a new option or by improving the positioning logic in some way

@strang3nt strang3nt marked this pull request as draft December 1, 2024 10:14
@strang3nt
Copy link
Author

Ok I get it. I came up with the following two options:

  1. Improve the positioning logic in such a way that if the document is not blank the pdf is appended, otherwise it has the current behavior (positioned at the top of the document)
  2. add a new option ("Append to document" maybe) which, if toggled, appends the pdf at the very end of the document. This new option is below the adjust-document option, and it is toggle-able only if adjust document itself is toggled.

I personally prefer the second option, which seems clearer from a user perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve PDF adjust-document import option to import at view position
2 participants