(Fixes cross compilation) Default to using glib-compile-resources bin before using glib_build_tools crate #1223
Conversation
…ary as the default option and fallback to glib_build_tools make the glib_build_tools crate optional which is used only when target == host If cross compiling and glib-compile-resources is not found then glib_build_tools will be skipped and instead an error telling the user to install the glib dev tools will be outputted If compiling natively, then it'll proceed to using glib_build_tools crate assuming glib-compile-resources failed
|
Thanks. I wonder if this can be refactored so that the feature is not needed (and does not have to be enabled programmatically). It seems that it would also be possible to use a variable for this |
That's what I initially tried. However, during the building, rust would try to link glib_build_tools incorrectly resulting in that initial error.(This happens even if the glib_build_tools was explicitly wrapped inside an if false statement from my tests) This is why I had to use the optional feature instead |
| glib-build-tools = { workspace = true, optional = true } | ||
|
|
||
| [features] | ||
| use_glib_build_tools = ["glib-build-tools"] |
There was a problem hiding this comment.
It should be mentioned here that this feature is enabled progammatically in the build.rs file and not supposed to be used by the user
…ary as the default option and fallback to glib_build_tools
make the glib_build_tools crate optional which is used only when target == host
If cross compiling and glib-compile-resources(a linux binary from glib dev package) is not found then glib_build_tools will be skipped and instead an error telling the user to install the glib dev tools will be outputted
If compiling natively, then it'll proceed to first try using glib-compile-resources and if that fails, it'll fallback to the glib_build_tools crate
This is necessary, otherwise this error will get spout by crates/rnote-ui/build.rs when cross compiling