-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Lock tool style #1119
base: main
Are you sure you want to change the base?
feat: Lock tool style #1119
Conversation
- the template has to be changed to accomodate the use of the buttons - the buttons are not yet linked to the settings
- added to the gsettings - shoud sync with the toggle TODO - sync the value with the actual lock value - do the same for the pen modes
partial implementation of links between the pen choice and the settings button (only in that direction, the reverse still segfaults)
Well, I'm kinda stuck with a |
plus a couple of bug fixes
This finally works. Probably nitpicks to be fixed
Edit : done |
Seems like I still have |
Temporary to find what's going on
Finally working |
I'm thinking that maybe the logic has to be improved for touch inputs. Currently, if I use the eraser part (locked to the eraser) on the screen then immediately use touch to change the tool, the lock will appear. So maybe I should just consider that such a press has to be considered as a pen input and switches to the pen mode ? |
Fixes #1104
As of now the lock option is added with a overlay popup that allows unlocking the current pen tool (pen or eraser).
What's left to do is
I think it makes sense to add this in the Button Shortcuts portion of the settings with the added benefit of being able to change tools for pen/eraser there, and the dropdown (temporary/ ...) changed to a locked padlock/unlocked padlock toggle button