WIP: Block editing #150
Draft
WIP: Block editing #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .get_entities_with::<ChunkReceiver>() | ||
| .get_entities_with::<PlayerIdentity>() |
There was a problem hiding this comment.
Keep this as a ChunkReceiver, since you don't want to send play packets to someone in login state.
There was a problem hiding this comment.
There has to be a better solution that that. Also why would a player during login have a player identity?
There was a problem hiding this comment.
You're more than welcome to find a better solution, but, player receives the PlayerIdentity component during login start packet.
Oh wait, you also add ChunkReceiver during login start? Add it when login process is completed, and keep this as is. So 'everyone' would be players that could receive chunks I suppose?
0xnim
reviewed
Jan 4, 2025
| /// Reads an n-bit integer from a packed `i64`. | ||
| pub fn read_nbit_i32( | ||
| word: &i64, | ||
| bit_size: usize, |
There was a problem hiding this comment.
you state earlier that this must be 32 or less. so why not just u8?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: