feat: simplify configuration for SPA applications #94
Conversation
The initial implementation for SPAs required some unnecessary files to be created when running production build: This pull request removes the requirement for a build:server step and the existance of an ssr manifest when spa mode is set to `true`. This also adds a react-vanilla-spa example to show users how to configure this mode.
|
Hey @galvez, Thanks again for your time responding to #92. I dug a little deeper into the implementation and it looks to me like there were some unnecessary steps required to get SPA mode working in production. I removed the check for the SSR manifest as well as the If you think this all makes sense I can update the docs as well to explain the setup a bit more. Cheers! |
| const bundle = {} | ||
| if (!dev) { | ||
| bundle.dir = resolve(vite.root, vite.build.outDir) | ||
| const indexHtmlPath = resolve(bundle.dir, 'client/index.html') |
There was a problem hiding this comment.
I left this as /dist/client, but it may make sense to remove this hard dependency on having a /client folder. SPAs should probably just use the /dist output (or at least allow for configuration)
Any thoughts on that?
There was a problem hiding this comment.
JSYK There's no hard dependency on having a client/ folder, root in vite.config.js can be the same folder as server.js and it should work fine.
Amazing work, I'll give it a go and review properly soon.
There was a problem hiding this comment.
Ok cool thanks!
What I meant here was that AFAICT, the output folder has to be /client right now for production. Unless there is a way of overriding how the production bundles are loaded that I missed.
|
I'm merging this PR as-is but I'm making the tweak on removing the |
|
@galvez thanks for reviewing! My pleasure, I’m glad it’s a useful contribution to the project 😃 |
The initial implementation for SPAs required some unnecessary files to be created when running production build: This pull request removes the requirement for a build:server step and the existence of an ssr manifest when spa mode is set to
true. This also adds a react-vanilla-spa example to show users how to configure this mode.Checklist
npm run testand the Code of conduct