-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor utility to run buck2 commands as a method to run arbitrary commands #48370
Open
rubennorte
wants to merge
5
commits into
facebook:main
Choose a base branch
from
rubennorte:export-D67600611
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+181
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Dec 23, 2024
This pull request was exported from Phabricator. Differential Revision: D67600611 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 23, 2024
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Differential Revision: D67600611
rubennorte
force-pushed
the
export-D67600611
branch
from
December 23, 2024 17:14
789ef76
to
4f47991
Compare
This pull request was exported from Phabricator. Differential Revision: D67600611 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D67600611 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 23, 2024
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Differential Revision: D67600611
rubennorte
force-pushed
the
export-D67600611
branch
from
December 23, 2024 20:27
4f47991
to
bf596ee
Compare
Differential Revision: D67600610
Differential Revision: D67549203
Differential Revision: D67602299
Differential Revision: D67600616
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Dec 27, 2024
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Reviewed By: javache Differential Revision: D67600611
rubennorte
force-pushed
the
export-D67600611
branch
from
December 27, 2024 23:40
bf596ee
to
9d84329
Compare
This pull request was exported from Phabricator. Differential Revision: D67600611 |
…ommands (facebook#48370) Summary: Pull Request resolved: facebook#48370 Changelog: [internal] Small refactor in preparation for async commands with streaming. Reviewed By: javache Differential Revision: D67600611
rubennorte
force-pushed
the
export-D67600611
branch
from
December 27, 2024 23:53
9d84329
to
74c9652
Compare
This pull request was exported from Phabricator. Differential Revision: D67600611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Small refactor in preparation for async commands with streaming.
Differential Revision: D67600611