Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm-to-yarn): add missing npm-to-yarn converter for Bun #10803

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

Lehoczky
Copy link
Contributor

@Lehoczky Lehoczky commented Dec 29, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Hi there 👋

This PR enables passing bun to the npm2yarn converter. The option is already available to the underlying npm-to-yarn package since v2.1.0 (and we are already using v3.0.0).

Test Plan

Test links

Deploy preview: https://deploy-preview-10803--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 29, 2024
Copy link

netlify bot commented Dec 29, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 3fbe331
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6771c9cdc567130008a60369
😎 Deploy Preview https://deploy-preview-10803--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🔴 47 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 51 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 73 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 47 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 64 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 73 🟢 100 🟢 100 🟠 86 Report

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Dec 30, 2024
@slorber slorber changed the title feat(npm-to-yarn): add support for Bun fix(npm-to-yarn): add missing npm-to-yarn converter for Bun Dec 30, 2024
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@slorber slorber merged commit 9800180 into facebook:main Dec 30, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants