Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: peer dependency warnings #10670

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: peer dependency warnings #10670

wants to merge 1 commit into from
+57 −2

Conversation

MorrisonCole
Copy link

@MorrisonCole MorrisonCole commented Nov 12, 2024 •
edited
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fixes #10668.

Addresses react, react-dom, & @mdx-js/react dependency issues only - note that there are few others that I've left unaddressed here.

Test Plan

To test this with a user project locally, it's necessary to bump the versions (e.g., with Verdaccio), since otherwise some of the transient dependencies will still point at the real published 3.6.1 versions and still log warnings.

  1. yarn test:build:website
  2. npm_config_registry="http://localhost:4873" npm init [email protected]
  3. Run npm_config_registry="http://localhost:4873" yarn from the new project

Note: if using yarn 2+, you must set up the registry differently: https://verdaccio.org/docs/setup-yarn/#yarn-modern-2x

To test with this repo, just run yarn.

Fresh project, with yarn 1.22.22

Before

warning "@docusaurus/core > [email protected]" has unmet peer dependency "react-loadable@*".
warning "@docusaurus/core > @docusaurus/mdx-loader > @mdx-js/mdx > recma-jsx > [email protected]" has unmet peer dependency "acorn@^6.0.0 || ^7.0.0 || ^8.0.0".
warning " > @mdx-js/[email protected]" has unmet peer dependency "@types/react@>=16".
warning "@docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
warning "@docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
warning "@docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "search-insights@>= 1 < 3".

After (no difference)

warning "@docusaurus/core > [email protected]" has unmet peer dependency "react-loadable@*".
warning "@docusaurus/core > @docusaurus/mdx-loader > @mdx-js/mdx > recma-jsx > [email protected]" has unmet peer dependency "acorn@^6.0.0 || ^7.0.0 || ^8.0.0".
warning " > @mdx-js/[email protected]" has unmet peer dependency "@types/react@>=16".
warning "@docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
warning "@docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
warning "@docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "search-insights@>= 1 < 3".

Fresh project, with yarn 3.5.0

Before

➤ YN0002: │ @algolia/autocomplete-core@npm:1.17.6 doesn't provide @algolia/client-search (pe7298), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-core@npm:1.17.6 doesn't provide algoliasearch (pd8765), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-core@npm:1.17.6 doesn't provide search-insights (p9bb2c), requested by @algolia/autocomplete-plugin-algolia-insights
➤ YN0002: │ @algolia/autocomplete-plugin-algolia-insights@npm:1.17.6 [1740a] doesn't provide @algolia/client-search (p7bc5e), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-plugin-algolia-insights@npm:1.17.6 [1740a] doesn't provide algoliasearch (p17755), requested by @algolia/autocomplete-shared
➤ YN0002: │ @docsearch/react@npm:3.7.0 [bcc48] doesn't provide @algolia/client-search (p165d9), requested by @algolia/autocomplete-preset-algolia
➤ YN0002: │ @docusaurus/bundler@npm:3.6.1 [63508] doesn't provide react (p2ea70), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/bundler@npm:3.6.1 [63508] doesn't provide react-dom (pdd21b), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/plugin-content-blog@npm:3.6.1 [32d4d] doesn't provide @mdx-js/react (p3ee28), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-content-docs@npm:3.6.1 [32d4d] doesn't provide @mdx-js/react (p83b6e), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-content-pages@npm:3.6.1 [32d4d] doesn't provide @mdx-js/react (pe14bf), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-debug@npm:3.6.1 [32d4d] doesn't provide @mdx-js/react (p9d30f), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-analytics@npm:3.6.1 [32d4d] doesn't provide @mdx-js/react (p58135), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-gtag@npm:3.6.1 [32d4d] doesn't provide @mdx-js/react (p47a8c), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-tag-manager@npm:3.6.1 [32d4d] doesn't provide @mdx-js/react (p684f8), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-sitemap@npm:3.6.1 [32d4d] doesn't provide @mdx-js/react (p2f703), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/preset-classic@npm:3.6.1 [4a25f] doesn't provide @mdx-js/react (p7b299), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-search-algolia@npm:3.6.1 [32d4d] doesn't provide @mdx-js/react (p0909e), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/utils-common@npm:3.6.1 doesn't provide react (pc078f), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/utils-common@npm:3.6.1 doesn't provide react-dom (p5bd66), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/utils@npm:3.6.1 doesn't provide react (p8d75d), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/utils@npm:3.6.1 doesn't provide react-dom (pb357f), requested by @docusaurus/types
➤ YN0002: │ recma-jsx@npm:1.0.0 doesn't provide acorn (p608e6), requested by acorn-jsx
➤ YN0002: │ yarn-warnings-repro@workspace:. doesn't provide @types/react (p04d1d), requested by @mdx-js/react

After (react, react-dom, & @mdx-js/react warnings resolved)

➤ YN0002: │ @algolia/autocomplete-core@npm:1.17.6 doesn't provide @algolia/client-search (pe7298), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-core@npm:1.17.6 doesn't provide algoliasearch (pd8765), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-core@npm:1.17.6 doesn't provide search-insights (p9bb2c), requested by @algolia/autocomplete-plugin-algolia-insights
➤ YN0002: │ @algolia/autocomplete-plugin-algolia-insights@npm:1.17.6 [1740a] doesn't provide @algolia/client-search (p7bc5e), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-plugin-algolia-insights@npm:1.17.6 [1740a] doesn't provide algoliasearch (p17755), requested by @algolia/autocomplete-shared
➤ YN0002: │ @docsearch/react@npm:3.7.0 [340ee] doesn't provide @algolia/client-search (p97d0c), requested by @algolia/autocomplete-preset-algolia
➤ YN0002: │ fixed-warnings@workspace:. doesn't provide @types/react (pc3f9f), requested by @mdx-js/react
➤ YN0002: │ recma-jsx@npm:1.0.0 doesn't provide acorn (p608e6), requested by acorn-jsx

This repo, with yarn 1.22.22

Before

warning " > @testing-library/[email protected]" has incorrect peer dependency "react@^16.9.0 || ^17.0.0".
warning " > @docusaurus/[email protected]" has unmet peer dependency "@mdx-js/react@^3.0.0".
warning "workspace-aggregator-2644423c-89df-4352-b18a-663f34c365dd > @docusaurus/plugin-ideal-image > @slorber/[email protected]" has unmet peer dependency "prop-types@>=15".
warning "workspace-aggregator-2644423c-89df-4352-b18a-663f34c365dd > @docusaurus/plugin-rsdoctor > @rsdoctor/[email protected]" has unmet peer dependency "@rspack/core@*".
warning "workspace-aggregator-2644423c-89df-4352-b18a-663f34c365dd > @docusaurus/plugin-rsdoctor > @rsdoctor/[email protected]" has unmet peer dependency "[email protected]".
warning "workspace-aggregator-2644423c-89df-4352-b18a-663f34c365dd > @docusaurus/plugin-rsdoctor > @rsdoctor/rspack-plugin > @rsdoctor/[email protected]" has unmet peer dependency "[email protected]".
warning "workspace-aggregator-2644423c-89df-4352-b18a-663f34c365dd > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
warning "workspace-aggregator-2644423c-89df-4352-b18a-663f34c365dd > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "search-insights@>= 1 < 3".
warning "workspace-aggregator-2644423c-89df-4352-b18a-663f34c365dd > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".

After (@mdx-js/react warning resolved)

warning " > @testing-library/[email protected]" has incorrect peer dependency "react@^16.9.0 || ^17.0.0".
warning "workspace-aggregator-ece3338e-ab49-4178-a47b-9af8158a8909 > @docusaurus/plugin-ideal-image > @slorber/[email protected]" has unmet peer dependency "prop-types@>=15".
warning "workspace-aggregator-ece3338e-ab49-4178-a47b-9af8158a8909 > @docusaurus/plugin-rsdoctor > @rsdoctor/[email protected]" has unmet peer dependency "@rspack/core@*".
warning "workspace-aggregator-ece3338e-ab49-4178-a47b-9af8158a8909 > @docusaurus/plugin-rsdoctor > @rsdoctor/[email protected]" has unmet peer dependency "[email protected]".
warning "workspace-aggregator-ece3338e-ab49-4178-a47b-9af8158a8909 > @docusaurus/plugin-rsdoctor > @rsdoctor/rspack-plugin > @rsdoctor/[email protected]" has unmet peer dependency "[email protected]".
warning "workspace-aggregator-ece3338e-ab49-4178-a47b-9af8158a8909 > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".
warning "workspace-aggregator-ece3338e-ab49-4178-a47b-9af8158a8909 > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "search-insights@>= 1 < 3".
warning "workspace-aggregator-ece3338e-ab49-4178-a47b-9af8158a8909 > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-core > @algolia/[email protected]" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6".

This repo, with yarn 3.5.0

Before

➤ YN0002: │ @algolia/autocomplete-core@npm:1.9.3 doesn't provide @algolia/client-search (pbc410), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-core@npm:1.9.3 doesn't provide algoliasearch (p8ad5b), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-core@npm:1.9.3 doesn't provide search-insights (pfdb70), requested by @algolia/autocomplete-plugin-algolia-insights
➤ YN0002: │ @algolia/autocomplete-plugin-algolia-insights@npm:1.9.3 [e43f4] doesn't provide @algolia/client-search (pdf3b9), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-plugin-algolia-insights@npm:1.9.3 [e43f4] doesn't provide algoliasearch (p0f6bb), requested by @algolia/autocomplete-shared
➤ YN0002: │ @docsearch/react@npm:3.5.2 [0e4ac] doesn't provide @algolia/client-search (p796ce), requested by @algolia/autocomplete-preset-algolia
➤ YN0002: │ @docsearch/react@npm:3.5.2 [635fe] doesn't provide @algolia/client-search (p0242f), requested by @algolia/autocomplete-preset-algolia
➤ YN0002: │ @docusaurus/bundler@workspace:packages/docusaurus-bundler doesn't provide react (p8bd3f), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/bundler@workspace:packages/docusaurus-bundler doesn't provide react-dom (pb01e3), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/bundler@workspace:packages/docusaurus-bundler [5105c] doesn't provide react (p0128d), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/bundler@workspace:packages/docusaurus-bundler [5105c] doesn't provide react-dom (p8f7e2), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/faster@workspace:packages/docusaurus-faster doesn't provide react (p8751c), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/faster@workspace:packages/docusaurus-faster doesn't provide react-dom (p0290f), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/lqip-loader@workspace:packages/lqip-loader doesn't provide webpack (p6b2fd), requested by file-loader
➤ YN0002: │ @docusaurus/plugin-client-redirects@workspace:packages/docusaurus-plugin-client-redirects doesn't provide @mdx-js/react (p31cf2), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-client-redirects@workspace:packages/docusaurus-plugin-client-redirects [86937] doesn't provide @mdx-js/react (pc71f5), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-content-blog@workspace:packages/docusaurus-plugin-content-blog doesn't provide @mdx-js/react (pcd87e), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-content-blog@workspace:packages/docusaurus-plugin-content-blog [c7c55] doesn't provide @mdx-js/react (pf684d), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-content-blog@workspace:packages/docusaurus-plugin-content-blog [cff45] doesn't provide @mdx-js/react (pd00bf), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-content-docs@workspace:packages/docusaurus-plugin-content-docs doesn't provide @mdx-js/react (pd74fa), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-content-docs@workspace:packages/docusaurus-plugin-content-docs [c7c55] doesn't provide @mdx-js/react (p40ca4), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-content-docs@workspace:packages/docusaurus-plugin-content-docs [cff45] doesn't provide @mdx-js/react (pae639), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-content-pages@workspace:packages/docusaurus-plugin-content-pages doesn't provide @mdx-js/react (p84849), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-content-pages@workspace:packages/docusaurus-plugin-content-pages [c7c55] doesn't provide @mdx-js/react (pef5a6), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-content-pages@workspace:packages/docusaurus-plugin-content-pages [cff45] doesn't provide @mdx-js/react (pf8da8), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-debug@workspace:packages/docusaurus-plugin-debug doesn't provide @mdx-js/react (p0bcec), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-debug@workspace:packages/docusaurus-plugin-debug [c7c55] doesn't provide @mdx-js/react (pfad00), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-debug@workspace:packages/docusaurus-plugin-debug [cff45] doesn't provide @mdx-js/react (p56294), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-analytics@workspace:packages/docusaurus-plugin-google-analytics doesn't provide @mdx-js/react (p20252), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-analytics@workspace:packages/docusaurus-plugin-google-analytics [c7c55] doesn't provide @mdx-js/react (p8e7cb), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-analytics@workspace:packages/docusaurus-plugin-google-analytics [cff45] doesn't provide @mdx-js/react (p9e4f7), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-gtag@workspace:packages/docusaurus-plugin-google-gtag doesn't provide @mdx-js/react (pdd7e2), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-gtag@workspace:packages/docusaurus-plugin-google-gtag [c7c55] doesn't provide @mdx-js/react (p41571), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-gtag@workspace:packages/docusaurus-plugin-google-gtag [cff45] doesn't provide @mdx-js/react (p3fe01), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-tag-manager@workspace:packages/docusaurus-plugin-google-tag-manager doesn't provide @mdx-js/react (pd1206), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-tag-manager@workspace:packages/docusaurus-plugin-google-tag-manager [c7c55] doesn't provide @mdx-js/react (p2acef), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-google-tag-manager@workspace:packages/docusaurus-plugin-google-tag-manager [cff45] doesn't provide @mdx-js/react (peb4f8), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-ideal-image@workspace:packages/docusaurus-plugin-ideal-image doesn't provide @mdx-js/react (p98252), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-ideal-image@workspace:packages/docusaurus-plugin-ideal-image doesn't provide prop-types (p317de), requested by @slorber/react-ideal-image
➤ YN0002: │ @docusaurus/plugin-ideal-image@workspace:packages/docusaurus-plugin-ideal-image [86937] doesn't provide @mdx-js/react (p558ed), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-ideal-image@workspace:packages/docusaurus-plugin-ideal-image [86937] doesn't provide prop-types (p5ee07), requested by @slorber/react-ideal-image
➤ YN0002: │ @docusaurus/plugin-pwa@workspace:packages/docusaurus-plugin-pwa doesn't provide @docusaurus/plugin-content-docs (pa4cd2), requested by @docusaurus/theme-common
➤ YN0002: │ @docusaurus/plugin-pwa@workspace:packages/docusaurus-plugin-pwa doesn't provide @mdx-js/react (p959b6), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-pwa@workspace:packages/docusaurus-plugin-pwa [86937] doesn't provide @docusaurus/plugin-content-docs (pd5914), requested by @docusaurus/theme-common
➤ YN0002: │ @docusaurus/plugin-pwa@workspace:packages/docusaurus-plugin-pwa [86937] doesn't provide @mdx-js/react (p95a71), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-rsdoctor@workspace:packages/docusaurus-plugin-rsdoctor doesn't provide @mdx-js/react (p3d711), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-rsdoctor@workspace:packages/docusaurus-plugin-rsdoctor doesn't provide @rspack/core (p391dc), requested by @rsdoctor/rspack-plugin
➤ YN0002: │ @docusaurus/plugin-rsdoctor@workspace:packages/docusaurus-plugin-rsdoctor doesn't provide webpack (p4bcf1), requested by @rsdoctor/webpack-plugin
➤ YN0002: │ @docusaurus/plugin-rsdoctor@workspace:packages/docusaurus-plugin-rsdoctor [86937] doesn't provide @mdx-js/react (pdb463), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-rsdoctor@workspace:packages/docusaurus-plugin-rsdoctor [86937] doesn't provide @rspack/core (p32ba4), requested by @rsdoctor/rspack-plugin
➤ YN0002: │ @docusaurus/plugin-rsdoctor@workspace:packages/docusaurus-plugin-rsdoctor [86937] doesn't provide webpack (p24503), requested by @rsdoctor/webpack-plugin
➤ YN0002: │ @docusaurus/plugin-sitemap@workspace:packages/docusaurus-plugin-sitemap doesn't provide @mdx-js/react (p7a110), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-sitemap@workspace:packages/docusaurus-plugin-sitemap [c7c55] doesn't provide @mdx-js/react (p4e713), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-sitemap@workspace:packages/docusaurus-plugin-sitemap [cff45] doesn't provide @mdx-js/react (p6be99), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-vercel-analytics@workspace:packages/docusaurus-plugin-vercel-analytics doesn't provide @mdx-js/react (p7ae92), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/preset-classic@workspace:packages/docusaurus-preset-classic doesn't provide @mdx-js/react (p3ee25), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/preset-classic@workspace:packages/docusaurus-preset-classic [d642b] doesn't provide @mdx-js/react (pfbec3), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common doesn't provide @mdx-js/react (p2c9c2), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common doesn't provide typescript (p2dbfc), requested by schema-dts
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [7ff0b] doesn't provide @mdx-js/react (pf50a8), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [7ff0b] doesn't provide typescript (pc468b), requested by schema-dts
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [85847] doesn't provide @mdx-js/react (pcc97b), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [85847] doesn't provide typescript (p403ff), requested by schema-dts
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [86937] doesn't provide @mdx-js/react (p33c65), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [86937] doesn't provide typescript (p5c267), requested by schema-dts
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [c7c55] doesn't provide @mdx-js/react (p1fc9e), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [c7c55] doesn't provide typescript (p23a01), requested by schema-dts
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [cff45] doesn't provide @mdx-js/react (pff4fb), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [cff45] doesn't provide typescript (p7f484), requested by schema-dts
➤ YN0002: │ @docusaurus/theme-live-codeblock@workspace:packages/docusaurus-theme-live-codeblock doesn't provide @docusaurus/plugin-content-docs (p28d80), requested by @docusaurus/theme-common
➤ YN0002: │ @docusaurus/theme-live-codeblock@workspace:packages/docusaurus-theme-live-codeblock doesn't provide @mdx-js/react (p07eb5), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-live-codeblock@workspace:packages/docusaurus-theme-live-codeblock [86937] doesn't provide @docusaurus/plugin-content-docs (p2dc0c), requested by @docusaurus/theme-common
➤ YN0002: │ @docusaurus/theme-live-codeblock@workspace:packages/docusaurus-theme-live-codeblock [86937] doesn't provide @mdx-js/react (p51a5c), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-mermaid@workspace:packages/docusaurus-theme-mermaid doesn't provide @docusaurus/plugin-content-docs (pe24ce), requested by @docusaurus/theme-common
➤ YN0002: │ @docusaurus/theme-mermaid@workspace:packages/docusaurus-theme-mermaid doesn't provide @mdx-js/react (p96689), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-mermaid@workspace:packages/docusaurus-theme-mermaid [86937] doesn't provide @docusaurus/plugin-content-docs (pd0438), requested by @docusaurus/theme-common
➤ YN0002: │ @docusaurus/theme-mermaid@workspace:packages/docusaurus-theme-mermaid [86937] doesn't provide @mdx-js/react (pbc777), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-search-algolia@workspace:packages/docusaurus-theme-search-algolia doesn't provide @mdx-js/react (p3964b), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-search-algolia@workspace:packages/docusaurus-theme-search-algolia [c7c55] doesn't provide @mdx-js/react (p78032), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-search-algolia@workspace:packages/docusaurus-theme-search-algolia [cff45] doesn't provide @mdx-js/react (p70df8), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-translations@workspace:packages/docusaurus-theme-translations doesn't provide @mdx-js/react (pbf524), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-translations@workspace:packages/docusaurus-theme-translations doesn't provide react (pad908), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/theme-translations@workspace:packages/docusaurus-theme-translations doesn't provide react-dom (p165a7), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/utils-common@workspace:packages/docusaurus-utils-common doesn't provide react (p02a5c), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/utils-common@workspace:packages/docusaurus-utils-common doesn't provide react-dom (pd395e), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/utils@workspace:packages/docusaurus-utils doesn't provide react (p06562), requested by @docusaurus/types
➤ YN0002: │ @docusaurus/utils@workspace:packages/docusaurus-utils doesn't provide react-dom (p39d0c), requested by @docusaurus/types
➤ YN0002: │ @lerna/legacy-package-management@npm:6.6.2 doesn't provide nx (pfc6c3), requested by @nrwl/devkit
➤ YN0002: │ @rsdoctor/core@npm:0.4.7 doesn't provide webpack (pfb8de), requested by @rsdoctor/types
➤ YN0002: │ @rsdoctor/graph@npm:0.4.7 doesn't provide webpack (pbc3b5), requested by @rsdoctor/types
➤ YN0002: │ @rsdoctor/rspack-plugin@npm:0.4.7 [f29c0] doesn't provide webpack (p627c7), requested by @rsdoctor/types
➤ YN0002: │ @rsdoctor/sdk@npm:0.4.7 doesn't provide webpack (pe9164), requested by @rsdoctor/types
➤ YN0002: │ @rsdoctor/utils@npm:0.4.7 doesn't provide webpack (pa9672), requested by @rsdoctor/types
➤ YN0002: │ docusaurus-2-classic-template@workspace:packages/create-docusaurus/templates/classic doesn't provide @types/react (pa196a), requested by @mdx-js/react
➤ YN0002: │ docusaurus-2-classic-typescript-template@workspace:packages/create-docusaurus/templates/classic-typescript doesn't provide @types/react (pcf980), requested by @mdx-js/react
➤ YN0002: │ recma-jsx@npm:1.0.0 doesn't provide acorn (p608e6), requested by acorn-jsx
➤ YN0002: │ website@workspace:website doesn't provide @docusaurus/plugin-content-docs (pee39e), requested by @docusaurus/theme-common
➤ YN0002: │ website@workspace:website doesn't provide @mdx-js/react (p4cd24), requested by @docusaurus/core
➤ YN0002: │ website@workspace:website doesn't provide eslint (pf4c4c), requested by @docusaurus/eslint-plugin

After (react, react-dom, & @mdx-js/react warnings resolved)

➤ YN0002: │ @algolia/autocomplete-core@npm:1.9.3 doesn't provide @algolia/client-search (pbc410), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-core@npm:1.9.3 doesn't provide algoliasearch (p8ad5b), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-core@npm:1.9.3 doesn't provide search-insights (pfdb70), requested by @algolia/autocomplete-plugin-algolia-insights
➤ YN0002: │ @algolia/autocomplete-plugin-algolia-insights@npm:1.9.3 [e43f4] doesn't provide @algolia/client-search (pdf3b9), requested by @algolia/autocomplete-shared
➤ YN0002: │ @algolia/autocomplete-plugin-algolia-insights@npm:1.9.3 [e43f4] doesn't provide algoliasearch (p0f6bb), requested by @algolia/autocomplete-shared
➤ YN0002: │ @docsearch/react@npm:3.5.2 [0e4ac] doesn't provide @algolia/client-search (p796ce), requested by @algolia/autocomplete-preset-algolia
➤ YN0002: │ @docsearch/react@npm:3.5.2 [635fe] doesn't provide @algolia/client-search (p0242f), requested by @algolia/autocomplete-preset-algolia
➤ YN0002: │ @docusaurus/lqip-loader@workspace:packages/lqip-loader doesn't provide webpack (p6b2fd), requested by file-loader
➤ YN0002: │ @docusaurus/plugin-ideal-image@workspace:packages/docusaurus-plugin-ideal-image doesn't provide prop-types (p317de), requested by @slorber/react-ideal-image
➤ YN0002: │ @docusaurus/plugin-ideal-image@workspace:packages/docusaurus-plugin-ideal-image [86937] doesn't provide prop-types (p5ee07), requested by @slorber/react-ideal-image
➤ YN0002: │ @docusaurus/plugin-rsdoctor@workspace:packages/docusaurus-plugin-rsdoctor doesn't provide @rspack/core (p391dc), requested by @rsdoctor/rspack-plugin
➤ YN0002: │ @docusaurus/plugin-rsdoctor@workspace:packages/docusaurus-plugin-rsdoctor doesn't provide webpack (p4bcf1), requested by @rsdoctor/webpack-plugin
➤ YN0002: │ @docusaurus/plugin-rsdoctor@workspace:packages/docusaurus-plugin-rsdoctor [86937] doesn't provide @rspack/core (p32ba4), requested by @rsdoctor/rspack-plugin
➤ YN0002: │ @docusaurus/plugin-rsdoctor@workspace:packages/docusaurus-plugin-rsdoctor [86937] doesn't provide webpack (p24503), requested by @rsdoctor/webpack-plugin
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common doesn't provide typescript (p2dbfc), requested by schema-dts
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [7ff0b] doesn't provide typescript (pc468b), requested by schema-dts
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [85847] doesn't provide typescript (p403ff), requested by schema-dts
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [a269e] doesn't provide typescript (p9c3e0), requested by schema-dts
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [c7c55] doesn't provide typescript (p23a01), requested by schema-dts
➤ YN0002: │ @docusaurus/theme-common@workspace:packages/docusaurus-theme-common [cff45] doesn't provide typescript (p7f484), requested by schema-dts
➤ YN0002: │ @lerna/legacy-package-management@npm:6.6.2 doesn't provide nx (pfc6c3), requested by @nrwl/devkit
➤ YN0002: │ @rsdoctor/core@npm:0.4.7 doesn't provide webpack (pfb8de), requested by @rsdoctor/types
➤ YN0002: │ @rsdoctor/graph@npm:0.4.7 doesn't provide webpack (pbc3b5), requested by @rsdoctor/types
➤ YN0002: │ @rsdoctor/rspack-plugin@npm:0.4.7 [f29c0] doesn't provide webpack (p627c7), requested by @rsdoctor/types
➤ YN0002: │ @rsdoctor/sdk@npm:0.4.7 doesn't provide webpack (pe9164), requested by @rsdoctor/types
➤ YN0002: │ @rsdoctor/utils@npm:0.4.7 doesn't provide webpack (pa9672), requested by @rsdoctor/types
➤ YN0002: │ docusaurus-2-classic-template@workspace:packages/create-docusaurus/templates/classic doesn't provide @types/react (pa196a), requested by @mdx-js/react
➤ YN0002: │ docusaurus-2-classic-typescript-template@workspace:packages/create-docusaurus/templates/classic-typescript doesn't provide @types/react (pcf980), requested by @mdx-js/react
➤ YN0002: │ recma-jsx@npm:1.0.0 doesn't provide acorn (p608e6), requested by acorn-jsx
➤ YN0002: │ website@workspace:website doesn't provide @types/react (p4df21), requested by @mdx-js/react
➤ YN0002: │ website@workspace:website doesn't provide eslint (pf4c4c), requested by @docusaurus/eslint-plugin

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#10668

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 12, 2024
@MorrisonCole MorrisonCole changed the title fix: peer dependencies warnings fix: peer dependency warnings Nov 12, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 2e68750
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6732ba2eb280d70008ebfabc
😎 Deploy Preview https://deploy-preview-10670--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 67 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 59 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 63 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 48 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 66 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟠 86 Report

MorrisonCole
MorrisonCole commented Nov 12, 2024
View reviewed changes
packages/docusaurus-plugin-client-redirects/package.json
@@ -32,6 +32,7 @@
"@docusaurus/types": "3.6.1"
},
"peerDependencies": {
"@mdx-js/react": "^3.0.0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each of the peers added in this PR, there were previously warnings like:

➤ YN0002: │ @docusaurus/plugin-client-redirects@workspace:packages/docusaurus-plugin-client-redirects doesn't provide @mdx-js/react (p31cf2), requested by @docusaurus/core
➤ YN0002: │ @docusaurus/plugin-client-redirects@workspace:packages/docusaurus-plugin-client-redirects [86937] doesn't provide @mdx-js/react (pc71f5), requested by @docusaurus/core

I've added additional peer dependency definitions as necessary, and then the dependency itself to the top level package (e.g., website).

@MorrisonCole MorrisonCole marked this pull request as ready for review November 12, 2024 03:05
@Josh-Cena
Copy link
Collaborator

Let's first figure out a good solution in #10668, because I don't like the idea of every package depending on MDX especially those that are supposed to work without any MDX plugins installed.

@slorber
Copy link
Collaborator

slorber commented Nov 19, 2024

Agree this is not ideal. This PR may fix the warning but not really the underlying problem we have in the first place.

Not sure how to handle this yet, but I'm thinking about it 😅

@slorber slorber marked this pull request as draft November 19, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsatisfied peer dependencies on fresh project with 3.6.1
4 participants
@MorrisonCole @Josh-Cena @slorber @facebook-github-bot