Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Rolls up a couple more changes to the agent and runtime for Dekaf:
Runtime::unary_materialize()
and route them todekaf::connector::unary_materialize()
. Doing it here instead of inbuild
allows more of Flow to interact with Dekaf tasks correctly:dry_run
publication (i.e avalidate
call) to fetch which fields to show. This now intercepts that call and correctly passes it to Dekaf because we setconnector_type
based on the endpoint inwalk_materialization()
:flow/crates/validation/src/materialization.rs
Lines 126 to 128 in 44dc0db
connector_tags
agent task calls a connector'sSpec
RPC, and we need to get Dekaf's endpoint/resource config schemas somehow so I figured rather than writing a thing to do it manually, all we need to do is sendconnector_type: ConnectorType::Dekaf
when we detect a task withimage_name
starting inghcr.io/estuary/dekaf-
.connector_tags
when processing a Dekaf row as obviously there's no image to pull.This change is