chore: fix review comments

enkryptcom · Jan 3, 2025 · b650e64 · b650e64
1 parent a38ed36
commit b650e64
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 10 deletions.
diff --git a/packages/extension/src/libs/networks-state/index.ts b/packages/extension/src/libs/networks-state/index.ts
@@ -23,9 +23,13 @@ class NetworksState {
     });
   }
 
+  /**
+   * Pins or unpins a network on the UI.
+   * @param targetNetworkName - the name of the network to set the status of
+   * @param isActive - represents whether or not the network is pinned on the ui
+   */
   async setNetworkStatus(
     targetNetworkName: string,
-    // isActive represents whether or not the network is pinned on the ui
     isActive: boolean,
   ): Promise<void> {
     const state: IState = await this.getState();

diff --git a/packages/extension/src/ui/action/App.vue b/packages/extension/src/ui/action/App.vue
@@ -537,12 +537,20 @@ onClickOutside(
   { ignore: [toggle] },
 );
 const setIsPinnedNetwork = async (network: string, isPinned: boolean) => {
-  await networksState.setNetworkStatus(network, isPinned);
-  await setActiveNetworks();
+  try {
+    await networksState.setNetworkStatus(network, isPinned);
+    await setActiveNetworks();
+  } catch (error) {
+    console.error('Failed to set pined network:', error);
+  }
 };
 
 const setIsToggledTestNetwork = async () => {
-  await setActiveNetworks();
+  try {
+    await setActiveNetworks();
+  } catch (error) {
+    console.error('Failed to set is toggled test network:', error);
+  }
 };
 </script>
 

diff --git a/packages/extension/src/ui/action/views/add-network/components/add-network-item.vue b/packages/extension/src/ui/action/views/add-network/components/add-network-item.vue
@@ -52,14 +52,15 @@ import { NodeType } from '@/types/provider';
 import { CustomEvmNetwork } from '@/providers/ethereum/types/custom-evm-network';
 import PinIcon from '@action/icons/actions/pin.vue';
 import customNetworkIcon from '@/ui/action/icons/common/custom-network-icon.vue';
+import { NetworkNames } from '@enkryptcom/types';
 
 const isHovered = ref(false);
 
 const emit = defineEmits<{
   (e: 'networkToggled', name: string, isActive: boolean): void;
   (e: 'networkDeleted', chainId: string): void;
   (e: 'update:pinNetwork', network: string, isPinned: boolean): void;
-  (e: 'testNetworkToggled', name: string, isActive: boolean): void;
+  (e: 'testNetworkToggled', name: NetworkNames, isActive: boolean): void;
 }>();
 
 const props = defineProps({

diff --git a/packages/extension/src/ui/action/views/network-assets/components/network-assets-header.vue b/packages/extension/src/ui/action/views/network-assets/components/network-assets-header.vue
@@ -18,7 +18,7 @@
 @import '@action/styles/theme.less';
 .network-assets {
   &__header {
-    padding: 10px 12px 2px 12px;
+    padding: 10px 16px 2px 16px;
     position: relative;
     display: flex;
     justify-content: space-between;
@@ -34,7 +34,7 @@
       margin: 0;
     }
     &__token {
-      width: 200px;
+      width: 196px;
       p {
         padding-left: 48px;
       }

diff --git a/packages/extension/src/ui/action/views/network-assets/components/network-assets-item.vue b/packages/extension/src/ui/action/views/network-assets/components/network-assets-item.vue
@@ -192,7 +192,7 @@ const toggleDetail = () => {
 .network-assets {
   &__token {
     height: 72px;
-    padding: 0 6px;
+    padding: 0 4px;
     position: relative;
     box-sizing: border-box;
     display: flex;
@@ -202,7 +202,7 @@ const toggleDetail = () => {
     border-radius: 10px;
     transition: background 300ms ease-in-out;
     text-decoration: none;
-    margin: 0 6px;
+    margin: 0 12px;
     cursor: pointer;
 
     &:hover {
@@ -214,7 +214,7 @@ const toggleDetail = () => {
       justify-content: flex-start;
       align-items: center;
       flex-direction: row;
-      width: 200px;
+      width: 196px;
       overflow: hidden;
 
       &.max {