-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor & Code-Cleaning #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeFactor found an issue: A closing curly bracket must not be preceded by a blank line. It's currently on: |
enisn
commented
Jan 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now can be merged without any breaking change
Namespace changes are disabled for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes no new feature. This is PR includes HUGE CORE CHANGES. As simple; these improvements that makes library more extensible & refactoring-easy. By the way, some of bug fixes are included in this PR.
AutoFilterer.Types
[ ] Chaining attributes (Markup Goals #18 )(v3)[ ] Nested support for CompareToAttribute (Nested Queries don't work with CompareToAttribute #17 )(v3)Migration guide to v2.6
Follow this document step by step if you're migration from v2.5.x to v2.6.x, if you're on older version, let's follow old migrations before this documentation:
1 - First step is 'Don't worry!' Just update your AutoFilterer nuget packages.
2 - Fix namespaces
AutoFilterer v2.6 comes with namespace changes.
AutoFilterer.Enums
changed asAutoFilterer
.CTRL
+H
( orCMD
+H
for Mac users.)using AutoFilterer.Enums;
for first box andusing AutoFilterer;
for second box.Entire Project
orEntire Solution
if you're using in multiple assembly.If some of files have duplicated
using AutoFilterer
line, you'll get warnings at compile-time. You can use resharper or similar tools to fix it.3 - Remove obsolete FilterBases
Only if you've
PaginationFilterBase<T>
type which is marked as obsolete before. You need to say good bye to it.PaginationFilterBase<T>
withPaginationFilterBase
. All behaviors are same! Check Step 1 and Dont' worry!4 - Remove CombineWith overrides
If you've overrided any of CombineWith() method, you shouldn't! Remove it and use Attribute Chaining feature.