installer: Use flatpak-bundler's freedesktop flatpakrefs #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if the freedesktop platform and SDK weren't installed, then electron-installer-flatpak would fail. This allows those runtimes to be auto-installed. https://phabricator.endlessm.com/T20128
|
Do we actually want to depend on FDo 1.4? The Flathub baseapp depends on 1.6. |
|
I'm merging this, since there are other places where this script uses the 1.4 runtime. We should separately look into updating it to 1.6. |
|
Yes, it would definitely be better to use the Flathub base app rather than the one in Watson's S3 bucket! |
|
Makes sense, filed #17 to track |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the freedesktop platform and SDK weren't installed, then
electron-installer-flatpak would fail. This allows those runtimes to be
auto-installed.
https://phabricator.endlessm.com/T20128