avoid collapsing exception groups from user code #2830
+86
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Dec 29, 2024
graingert
commented
Dec 29, 2024
graingert
commented
Dec 29, 2024
graingert
commented
Dec 29, 2024
Kludex
reviewed
Dec 30, 2024
| @@ -258,7 +259,7 @@ async def __call__(self, scope: Scope, receive: Receive, send: Send) -> None: | |||
| except OSError: | |||
| raise ClientDisconnect() | |||
| else: | |||
| async with anyio.create_task_group() as task_group: | |||
| async with create_collapsing_task_group() as task_group: | |||
There was a problem hiding this comment.
Do we also have an issue with StreamingResponse standalone?
With my comment on the other PR I was trying to avoid the changes here. 🤔
There was a problem hiding this comment.
Yeah it's the same sort of issue, but it's wrapped in two TaskGroups before the user gets the exception. Collapsing is ok here because if wait_for_disconnect raises an exception it is always 'catastrophic' eg won't be caught
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If user code is raising ExceptionGroups eg from TaskGroups or otherwise, they should get ExceptionGroups raised. There could also be important notes attached.
Checklist
No docs changes needed, probably should have made an issue for this.