Replace RuntimeError with WebSocketDisconnected #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
requested changes
Nov 25, 2024
Comment on lines
+25
to
+30
| class WebSocketDisconnected(RuntimeError): | ||
| """ | ||
| Raised when attempting to use a disconnected WebSocket. | ||
| """ | ||
|
|
||
| pass |
There was a problem hiding this comment.
That's not really what I meant... The exception already exists.
There was a problem hiding this comment.
Well, reading the code, WebSocketDisconnect seems to be called when you want to disconnect a socket, in these cases the socket is already disconnected. In my opinion, it would make more sense to create a new exception (WebSocketDisconnected). Tell me if you still want to use WebSocketDisconnect and if so I will make such changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change the exception raised if we attempt to use a disconnected WebSocket from
RuntimeErrortoWebSocketDisconnected.Discussed in #2762
Issue #2766
Checklist
I haven't changed the documentation, if there is a need for it I will gladly change it.