fix: get_locale follows posix standard #1264
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change brings the behavior of the
get_locale
function in theeww_shared_util
in line with the POSIX standard. Previously, the function relied exclusively on theLC_TIME
environment variable. However, this variable is almost never set because it is technically only needed if different locales are used for different categories.The changed function uses the environment variables
LC_ALL
,LC_TIME
, andLANG
in this specific order of preference. This order is prescribed by Section 8.2 of IEEE Std 1003.1-2008 as mandatory for implementations of that version of the POSIX standard, so this should blend in well in all environments that follow that standard.Additional Notes
I have classified this as a non-breaking change. It technically alters behavior on systems where both
LC_ALL
andLC_TIME
are set becauseLC_ALL
will now take precedence, but there are no API changes.The precise method of locale determination does not seem to be mentioned in the documentation, so I did not change anything there.
Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/main
directory has been adjusted to reflect my changes.cargo fmt
to automatically format all code before committing