Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powi/powf simplexpr functions #1255

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Conversation

ovalkonia
Copy link
Contributor

@ovalkonia ovalkonia commented Dec 23, 2024

Description

Yep, powi/powf, why not

Resolves #1226

Usage

In the showcase

Showcase

23-12-24 at 23:08:48

Additional Notes

Sooo, it's two separate expressions. They can be reduced down to a single one, that acts like powf. I just though it sometimes miiight be useful to have two of them. Just shrink it down to one expression if that's more appropriate

Checklist

  • All widgets I've added are correctly documented.
  • I added my changes to CHANGELOG.md, if appropriate.
  • The documentation in the docs/content/main directory has been adjusted to reflect my changes.
  • I used cargo fmt to automatically format all code before committing

Copy link
Contributor

@w-lfchen w-lfchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm at a glance, but maybe consider adding this to the grammar using operators as described in #1226. (i am currently unable to judge the feasibility of this)

@ovalkonia
Copy link
Contributor Author

consider adding this to the grammar using operators as described in #1226

I kinda like it more in the form of a function. I mean, if it's more appropriate to implement it the other way, I would. Although, I would prefer for it to be this way

@elkowar
Copy link
Owner

elkowar commented Dec 26, 2024

This seems fine to me, an operator would also work but I don't really see a massive benefit either way. I'll merge this! Thanks for your contribution!

@elkowar elkowar merged commit c3b28d8 into elkowar:master Dec 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] "pow" binary operation in simpleexpr
3 participants