ESQL: Fix ROUND() with unsigned longs throwing in some edge cases #119536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were 3 error cases with
ROUND(number, decimals)
:can't process [unsigned_long -> long]
in the cast evaluatorresolveType()
BigInteger.TEN.pow(...)
to throw aBigInteger would overflow supported range
Also, when the number is a BigInteger and the decimals is a big negative (but not big enough to throw), it may be very slow. Taking many seconds for a single computation (It tries to calculate a
10^(big number)
. I didn't do anything here, but I wonder if we should limit it.It's not an "error" in any case, so this PR is limited to the 500 errors.