Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package exclusion list in Splash screen only if it's needed #1554

Open
wants to merge 2 commits into
base: splash-speedrun-pt2
Choose a base branch
from
Open

Update package exclusion list in Splash screen only if it's needed #1554

wants to merge 2 commits into from

Conversation

anttimaki
Copy link
Collaborator

No description provided.

@anttimaki anttimaki requested a review from ebkr November 14, 2024 14:37
@anttimaki
Update package exclusion list in Splash screen only if it's needed
8f53e9e 
Exclusions are only needed to filter the package list read from API
before it's stored into IndexedDB. If the package list update is
skipped to get the user quickly into profile select view, we might
as well defer the update of exclusion list to when it's actually
needed.
@anttimaki
Fix an issue with exclusion list not getting updated when needed
9b6e8a8 
When updating the persistent cache, a sanity check ensured the
exclusion list loaded before trying to use it. However, as an empty
array was used as the default value (and the value used when the store
was reset), the sanity check never triggered.

It's unlikely this has caused issues before, as the exclusion list
should've always been updated before updating the persistent cache.
This however changed when Splash screen was changed to skip unnecessary
steps to get the user to profile selection screen faster.
ebkr
ebkr approved these changes Jan 5, 2025
View reviewed changes
Copy link
Owner

@ebkr ebkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I'd expect a change later to update the exclusion list alongside the "Failed to update mod list" banner though, or better, whenever we refresh the mod list.

It might already do this in which case feel free to correct me and disregard it entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebkr ebkr ebkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anttimaki @ebkr