Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More plotly results annotations #2375

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Heiner92
Copy link

Added more information on hover of results inside plotly graphs.

Note: I had to manually adjust the _version.py of pandapower in order to make the tests work. The reason being that the file-format version is already adjusted and does not match with the package version.

With the next release you would either have to change to a new main version 3.0 or change the logic in convert_format

@vogt31337
Copy link
Contributor

Thanks for your contribution. But could you please change the _version back to it's original? Since with the new release, it will be version 3.0.0.

@Heiner92
Copy link
Author

Heiner92 commented Sep 1, 2024

Thanks for your contribution. But could you please change the _version back to it's original? Since with the new release, it will be version 3.0.0.

Of course! I changed the version back. As a result some of the automatic tests should now fail.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 75.98%. Comparing base (11af12c) to head (f50ff97).
Report is 19 commits behind head on develop.

Files with missing lines Patch % Lines
pandapower/plotting/plotly/pf_res_plotly.py 0.00% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2375      +/-   ##
===========================================
- Coverage    76.00%   75.98%   -0.03%     
===========================================
  Files          282      282              
  Lines        32950    32961      +11     
===========================================
  Hits         25045    25045              
- Misses        7905     7916      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vogt31337
Copy link
Contributor

@Heiner92, I looked into your commit: The standard assumption of the units is wrong. pp normally calculates in MW, MVar and kA. Can you change the signature to reflect that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

power is normally measured in MW, current in kA. Voltage is in p.u. aka arbitrary units, which can be recalculated by multiplying res_bus.vm_pu with bus.vn_kv. So a binary switch which will change between pu and rated_voltage would suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants