Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option for valid time range to delete expired messages #1614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hamedzsmm
Copy link

@hamedzsmm hamedzsmm commented Nov 23, 2024

• Introduced a new configuration option to specify a valid time range for deleting expired messages.

• Updated the deletion logic to respect the configured time range, allowing deletions to occur only during specified hours (e.g., 1 AM to 6 AM).

• This change helps to avoid database locks during high load periods.

Description:

This PR introduces a new configuration option to specify a valid time range for deleting expired messages. The deletion logic has been updated to respect the configured time range, allowing deletions to occur only during specified hours (e.g., 1 AM to 6 AM). This change helps to avoid database locks during high load periods.

Issue(s) addressed:

Affected components:

  • CAP.Options and IDataStorage

How to test:

  • Configure the valid time range for deleting expired messages in the settings and verify that messages are only deleted within the specified time range.

Checklist:

  • [✓] I have tested my changes locally
  • [✓] I have added necessary documentation (if applicable)
  • [✓] I have updated the relevant tests (if applicable)
  • [✓] My changes follow the project's code style guidelines

•  Introduced a new configuration option to specify a valid time range for deleting expired messages.

•  Updated the deletion logic to respect the configured time range, allowing deletions to occur only during specified hours (e.g., 1 AM to 6 AM).

•  This change helps to avoid database locks during high load periods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant