Refactor Catalog API #659
Open
Refactor Catalog API #659
+169
−482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| api.MapPost("/items", CreateItem) | ||
| .WithName("CreateItem") | ||
| .WithSummary("Create a catalog item") | ||
| .WithDescription("Create a new item in the catalog"); | ||
| api.MapPut("/items/{id:int}", UpdateItem) |
There was a problem hiding this comment.
Do we want to retain the Items tag on this and the other items-related endpoints?
| { | ||
| var pageSize = paginationRequest.PageSize; | ||
| var pageIndex = paginationRequest.PageIndex; | ||
|
|
||
| var totalItems = await services.Context.CatalogItems | ||
| var root = (IQueryable<CatalogItem>)services.Context.CatalogItems; |
There was a problem hiding this comment.
Do we need the cast to IQueryable<CatalogItem> here?
| .LongCountAsync(); | ||
|
|
||
| var itemsOnPage = await services.Context.CatalogItems | ||
| .OrderBy(c => c.Name) | ||
| var itemsOnPage = await root |
There was a problem hiding this comment.
Looks like the ordering-by-name as removed here. Do we want to keep that?
| @@ -64,64 +64,10 @@ | |||
| } | |||
| ] | |||
| }, | |||
| "route4": { | |||
There was a problem hiding this comment.
Should we keep the api-version query parameter here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Catalog API to adopt more commonly accepted REST API conventions.
Fixes #589.