Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/VideoCommon: Fix duplicate OSD Custom Textures messages #13244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dreamsyntax
Copy link
Member

@dreamsyntax dreamsyntax commented Dec 27, 2024

Resolves duplicate OSD messages for Loading and Found custom textures.

Upon VideoBackend initialization HiresTexture::Init will be called, which previously called HiresTexture::Update.
This PR removes HiresTexture::Init as it no longer serves a purpose.

Before:
image

After:
image

Reproduce Steps:

  1. Enable Graphics -> Advanced -> Load Custom Textures
  2. (Optional) Enable Prefetch Custom Textures (this changes the message between Loading and Found)
  3. Launch a game
  4. Observe the double message

Suggested Testing:

  1. Test with game window embedded in Main Window, and without
  2. Test with DynamicInputTexture scenarios
  3. Test with multi-layer texture scenarios (e.g. 'GUP' folder and 'GUPR8P' folder)
  4. Launching a game from the Wii menu and make sure the textures load. - iwubcode

@iwubcode
Copy link
Contributor

One other thing that probably needs to be tested: launching a game from the Wii menu and make sure the textures load..

@dreamsyntax
Copy link
Member Author

dreamsyntax commented Dec 27, 2024

It turns out 3x can occur for Wii menu:
image

The launching a game from wii menu failed to refresh textures, so I'll be swapping the removed call to keep the gameID change instead.

@dreamsyntax dreamsyntax changed the title Core/ConfigManager: Remove duplicate HiresTexture::Update Core/ConfigManager: Fix duplicate OSD Custom Textures messages Dec 27, 2024
@dreamsyntax dreamsyntax force-pushed the bugfix-double-osd-texture-messages branch from 28959dc to 38b0234 Compare December 27, 2024 06:02
@dreamsyntax
Copy link
Member Author

It turns out 3x can occur for Wii menu:

With the latest commit, now it is 2x. This is expected as the Title loaded changes twice within the Wii Menu on boot (before entering a game).

My own testing (linux):

  • Test with game window embedded in Main Window, and without ✔️
  • Test with multi-layer texture scenarios (e.g. 'GUP' folder and 'GUPR8P' folder) ✔️
  • Launching a game from the Wii menu and make sure the textures load. - iwubcode ✔️

I have not tested:

  • Test with DynamicInputTexture scenarios

@dreamsyntax dreamsyntax changed the title Core/ConfigManager: Fix duplicate OSD Custom Textures messages Core/VideoCommon: Fix duplicate OSD Custom Textures messages Dec 27, 2024
@dreamsyntax
Copy link
Member Author

dreamsyntax commented Dec 28, 2024

Removing init seems to behave exactly the same; I would just need someone to OK the solution.

@dreamsyntax dreamsyntax force-pushed the bugfix-double-osd-texture-messages branch 3 times, most recently from f0e0b84 to c9d05ad Compare December 28, 2024 08:09
Resolves duplicate OSD messages for Loading and Found custom textures.
VideoBackend initialization results in HiresTexture::Init being called.
We already call HiresTexture::Update when OnNewTitleLoad is called.
Thus we can remove HiresTextures::Init completely as it is redundant.
@dreamsyntax dreamsyntax force-pushed the bugfix-double-osd-texture-messages branch from c9d05ad to 07f712f Compare December 28, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants