-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core/VideoCommon: Fix duplicate OSD Custom Textures messages #13244
base: master
Are you sure you want to change the base?
Core/VideoCommon: Fix duplicate OSD Custom Textures messages #13244
Conversation
One other thing that probably needs to be tested: launching a game from the Wii menu and make sure the textures load.. |
28959dc
to
38b0234
Compare
With the latest commit, now it is 2x. This is expected as the Title loaded changes twice within the Wii Menu on boot (before entering a game). My own testing (linux):
I have not tested:
|
Removing init seems to behave exactly the same; I would just need someone to OK the solution. |
f0e0b84
to
c9d05ad
Compare
Resolves duplicate OSD messages for Loading and Found custom textures. VideoBackend initialization results in HiresTexture::Init being called. We already call HiresTexture::Update when OnNewTitleLoad is called. Thus we can remove HiresTextures::Init completely as it is redundant.
c9d05ad
to
07f712f
Compare
Resolves duplicate OSD messages for Loading and Found custom textures.
Upon VideoBackend initialization HiresTexture::Init will be called, which previously called HiresTexture::Update.
This PR removes HiresTexture::Init as it no longer serves a purpose.
Before:
After:
Reproduce Steps:
Suggested Testing: