Android: Fix VSync option not working #13235
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It happened due to a typo from SECTION_GFX_HARDWARE
|
Considering Android enforces Vsync, is it possible to test this? I mean, I'm fine with merging it as is as it seems like a clear oops fix. But it would be nice to verify that the control is working, if at all possible. |
JosJuice
approved these changes
Dec 31, 2024
There was a problem hiding this comment.
I don't have a way to test it myself, which is probably how this got merged in this broken state. Let's just merge this IMO.
Supposedly there are certain users who notice a difference with the VSync setting enabled, but I don't understand how that can be the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happened due to a typo from SECTION_GFX_HARDWARE