Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat issue #134: support linux mint by checking /etc/os-release for ID_LIKE and UBUNTU_CODENAME #185

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ptandler
Copy link

I just tried to install docker under mint 20 and this script failed: it was detected as debian.
Luckily, Mint provides information about the base distro in /etc/os-release:

NAME="Linux Mint"
VERSION="20 (Ulyana)"
ID=linuxmint
ID_LIKE=ubuntu  ### check this
PRETTY_NAME="Linux Mint 20"
VERSION_ID="20"
HOME_URL="https://www.linuxmint.com/"
SUPPORT_URL="https://forums.ubuntu.com/"
BUG_REPORT_URL="http://linuxmint-troubleshooting-guide.readthedocs.io/en/latest/"
PRIVACY_POLICY_URL="https://www.linuxmint.com/"
VERSION_CODENAME=ulyana
UBUNTU_CODENAME=focal  ### and this

I wasn't able to test this on all other distros. However, assuming that the entries in /etc/os-release are standardized, the changes should be safe.

@ptandler ptandler changed the title feat: support linux mint by checking /etc/os-release for ID_LIKE and UBUNTU_CODENAME feat issue #134: support linux mint by checking /etc/os-release for ID_LIKE and UBUNTU_CODENAME Aug 15, 2020
… for ID_LIKE and UBUNTU_CODENAME

Signed-off-by: Peter Tandler <[email protected]>
@ptandler ptandler force-pushed the issue134-mint-support branch from 33a82d2 to ec1c828 Compare August 15, 2020 21:13
@ptandler
Copy link
Author

alright, seems like ubuntu and other use these fields as well :-( Thought it was easy.
Trying to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant