Improve PGDATA warning about anonymous volumes #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The people who most need to see this warning will struggle to understand the meaning of the pre-existing language. This updated warning: - Refers to anonymous volumes by their correct name. - Describes where the mystery mount is coming from. - States the required behavior quite plainly, you must mount at the correct location. For additional context see: https://stackoverflow.com/a/76217607
|
I would put the more important part first. The important info is about persisting the data so that should be among the first thing in the sentence. |
mikelococo
commented
Nov 28, 2024
|
Committed, I think we're ready for a merge. |
LaurentGoderre
approved these changes
Dec 2, 2024
tianon
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The people who most need to see this warning will struggle to understand the meaning of the pre-existing language.
This updated warning:
For additional context see:
https://stackoverflow.com/a/76217607