Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use prettier library and clean up the codebase #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gammons
Copy link

@gammons gammons commented Sep 19, 2022

This codebase is hard to read and needs a bit of standardization with linting. There were also a lot of commented out code and superfluous newlines. This PR helps normalize the codebase so it will be easier to contribute to.

  • removed commented-out code
  • Removed superfluous newlines
  • Cleaned up spacing
  • Add prettier to devDependencies in package.json

This PR is similar to #40, but I also added prettier to the devDependencies as well.

For a formatting change like this, it's best to rip the band-aid off quickly, since it changed a lot of code. But it will make it easier to contribute to going forward.

One major caveat - I was not able to test this locally because of #62 . Care should be taken to validate that this PR works before even considering merging.

@SassNinja
Copy link

Any update on this topic?

I also immediately noticed the inconsistent code format when starting to read this project's code. Would definitely improve readability if prettier is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants