Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up history by removing entries for non-existent images and im… #367

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AEtheve
Copy link
Contributor

@AEtheve AEtheve commented Jan 2, 2023

…plemented disk cleanup when deleting from history.

…plemented disk cleanup when deleting from history.
@divamgupta
Copy link
Owner

Thanks for the PR.
I see one case on which it might fail.
Say you have in image X, then you use X for img2img, then you delete X from history. In that case it should not be deleted from the disk as it still needs to be there in history.

@divamgupta
Copy link
Owner

Maybe a cleaner solution is followed:
On startup, do ls on the image folders, and delete the images which are not present in the history object.

@Leland
Copy link

Leland commented Feb 25, 2023

Resolves #121

@SassNinja
Copy link

Any update here?

I'm facing the same issue: when deleting an image in history I expect it to be gone (and not still existing on disk)

Currently it's quite intransparent as there's no hint the image still exists after clearing the history. This PR would be an important improvement! (also solves #493 btw)

@divamgupta are you suggesting to do the cleanup not in History.vue but a different file?

I consider jumping in (if nobody is working on this topic anymore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants