-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merging user service with connection manager #6225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamayushm
requested review from
vikramdevtron,
nishant-d,
prakarsh-dt and
vivek-devtron
as code owners
December 27, 2024 10:51
nishant-d
requested changes
Dec 30, 2024
Quality Gate passedIssues Measures |
iamayushm
changed the title
merging user service with connection manager
chore: merging user service with connection manager
Jan 2, 2025
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
Jan 2, 2025
The migration files have successfully passed the criteria!! |
nishant-d
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Earlier we use to pass token in getConnection() function in "github.com/devtron-labs/devtron/client/argocdServer/connection" from outside, now we will be reading token inside getConnection func from outside.
For achieving point 1, argocdUserService is merged with argocdConnectionManager
All usages for setting argoCD token in context is removed
For resolving some circular imports, one method is refactored into clusterReadService, all it's usages are changed and some things are moved into bean.
Future refactoring scope:-
Checklist:
Does this PR introduce a user-facing change?