Upgrade to TypeScript 4.5.4 #6115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
added
the
type: chore
|
I might need to try this again because the approach that I took doesn't seem to be right. I'll try doing this again in a few days. |
erezrokah
force-pushed
the
tm/upgrade-typescript
branch
from
42fab77 to
a223996
Compare
1 task
erezrokah
force-pushed
the
tm/upgrade-typescript
branch
from
a223996 to
5b0b030
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Dependencies are a mess right now, so they will be updated as part of a PR by maintainers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Blocking #6106
NetlifyCMS project is currently built with TypeScript 3.9.10. In #6106, I upgraded AJV to 8.8.2 which was built with TypeScript 4+. The type definitions for AJV@8 include syntax that current version of TypeScript doesn't support. As a result, in #6106, the build is failing because it can't compile TypeScript. This PR attempts to upgrade version of TypeScript to 4.5.4 to allow us building with TypeScript 4+.
Most of the changes were around error handling. I'm using type guards to detect presence of
error.messageproperty. There is one type error that I'm not sure about - it's around handling of response from GraphQL. I'll check with me team tomorrow and update this PR.Test plan
Checklist
Please add a
xinside each checkbox:yarn format.yarn test.A picture of a cute animal (not mandatory but encouraged)