Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Access-Control-Allow-Origin header to response #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JervenBolleman
Copy link

To make it easier to develop JS webapps against sparql-proxy we set the CORS header to '*'. There is a cors config to turn it off

…he CORS header to '*'. There is a cors config to turn it off
@skwsm skwsm requested a review from ursm September 6, 2019 05:08
@ursm
Copy link
Collaborator

ursm commented Sep 6, 2019

Thank you for your suggestion. We will already provide the same functionality through cors() express middleware. Isn't it working as you expected?

router.all('/sparql', cors(), multer().array(), async (req, res) => {

image

@JervenBolleman
Copy link
Author

We where confused because these are not set on error pages such as 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants