Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove brand fonts #3563

Merged
merged 20 commits into from
Jan 2, 2025
Merged

refactor: remove brand fonts #3563

merged 20 commits into from
Jan 2, 2025

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Dec 6, 2024

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Dec 6, 2024
@mfranzke mfranzke self-assigned this Dec 6, 2024
@github-actions github-actions bot added the 🏗foundations Changes inside foundations folder label Dec 6, 2024
Copy link
Contributor

github-actions bot commented Dec 6, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-remove-brand-fonts

@mfranzke mfranzke added this to the v0.6.0 milestone Dec 6, 2024
@github-actions github-actions bot added the 📕documentation Improvements or additions to documentation label Dec 6, 2024
@mfranzke mfranzke modified the milestones: v0.6.0, v0.7.0 Dec 7, 2024
@mfranzke
Copy link
Member Author

mfranzke commented Dec 18, 2024

@nmerget @TOberpaul I do see three different options of how to proceed with this:

  • Use DB Non Latin
  • Use any general "safe" font definition like e.g. Helvetica.
  • Use Google Noto.

To my understanding we've agreed on the first option, the second would make sense as well strategic-wise. But we shouldn't proceed with the third, as especially the first one would be a simpler one, and second more accurate to the expected result in companies context usage.

@mfranzke mfranzke merged commit 8cb886b into main Jan 2, 2025
73 checks passed
mfranzke added a commit that referenced this pull request Jan 2, 2025
* refactor: remove brand fonts

* chore: replace fonts with NotoSans

* chore: update snapshots

* fix: issue with prepare for foundations

* chore: update snapshots

* refactor: removed the fonts from the listing

* Create v0.6.x-to-v0.7.x.md

* Update v0.6.x-to-v0.7.x.md

* Update v0.6.x-to-v0.7.x.md

* test: regenerated snapshots

* test: regenerated snapshots

* test: regenerated snapshots

* test: regenerated snapshots

---------

Co-authored-by: Nicolas Merget <[email protected]>
Co-authored-by: Nicolas Merget <[email protected]>
@mfranzke mfranzke deleted the refactor-remove-brand-fonts branch January 2, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder 🍄🆙improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants